corwin/card-game.el
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Replace bid-net advice with a dispatch seam; MELPA review cleanups

Browse source 
Address riscy's first-pass review of MELPA PR #10147.

* card-games-bid-ui.el (card-games-bid-submit): New generic; the four
player commands validate once and submit through it.
(card-games-bid-after-refresh-hook): New hook run after refresh.
(card-games-bid-mode-map): Bind "s" here, not from bid-net at load.
* card-games-bid-net.el (card-games-bid-client-game): New subclass
whose card-games-bid-submit method forwards intents to the host.
Remove all six top-level advice-adds and the top-level define-key.
* card-games-bid.el (card-games-bid-inhibit-prompts): New variable
replacing the nominate-suit advice.
* card-games-core.el, card-games-gaps.el, card-games-crapette.el,
card-games-solitaire.el, card-games-trick-ext.el, card-games-bid-ui.el:
Docstring widths, checkdoc disambiguations, sharp-quoted defalias,
derived-mode-p, require NOERROR.
* test/card-games-tests.el: Six new tests pinning the no-advice
contract and the dispatch seam.
* Bump to 1.0.92; NEWS entry; regenerate README.md.

Assisted-by: Claude:claude-fable-5
This commit is contained in:
Corwin Brust 2026-08-16 09:51:47 -05:00
parent ff7a9f6e49
commit 1a5d23d39e
33 changed files with 359 additions and 186 deletions
Download patch file Download diff file Expand all files Collapse all files

15
card-games-bid.el
View file

@ -4,7 +4,7 @@
;; Author: Corwin Brust <corwin@bru.st>
;; Maintainer: Corwin Brust <corwin@bru.st>
;; Version: 1.0.91
;; Version: 1.0.92
;; Keywords: games
;; URL: https://code.bru.st/corwin/card-game.el
@ -217,6 +217,12 @@ Trumps lead (strongest first), then each side suit runs high to low."
(defvar card-games-bid--human-seats '(0)
"List of seats controlled by a human player. South is seat 0.")
(defvar card-games-bid-inhibit-prompts nil
"When non-nil, choices that would prompt fall back to the AI's pick.
The network layer binds this while the host applies a remote player's
move: the seat belongs to a human, but one at another Emacs, so a
local minibuffer prompt could never reach them.")
(defconst card-games-bid-seat-names ["South" "West" "North" "East"]
"Seat labels; partners sit opposite (0/2 and 1/3).")
@ -412,9 +418,12 @@ Trumps lead (strongest first), then each side suit runs high to low."
(card-games-put game :turn (card-games-bid--next-seat game seat)))))
(defun card-games-bid--nominate-suit (game seat)
"Choose the suit GAME SEAT nominates when the Joker leads under no-trump."
"Choose the suit GAME SEAT nominates when the Joker leads under no-trump.
A local human is prompted; the AI, or a human seat while
`card-games-bid-inhibit-prompts' is non-nil, takes the longest suit."
(let ((hand (card-games-bid--hand game seat)))
(if (card-games-bid--human-p seat)
(if (and (card-games-bid--human-p seat)
(not card-games-bid-inhibit-prompts))
(let ((ch (read-char-choice
"Joker leads — nominate a suit [s]pades [c]lubs [d]iamonds [h]earts: "
'(?s ?c ?d ?h))))