corwin/card-game.el
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Require subr-x in card-games-net; skip SVG tests without SVG

Browse source 
card-games-net.el calls string-empty-p, which lives in subr-x before
Emacs 29; without the require a fresh Emacs 27 reported a void function
in every networked test.  The SVG smoke and region tests now skip when
the Emacs has no SVG support, so the suite reads 145 expected, 20
skipped there instead of 25 failures.

* card-games-net.el: Require subr-x.
* test/card-games-tests.el: Skip the SVG tests unless SVG is available.
* NEWS: Note both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U2Fb1SzFi8UuJdUm96qx83
This commit is contained in:
Corwin Brust 2026-10-04 19:09:07 +00:00
parent 1a5d23d39e
commit e78fe38381
3 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
NEWS
View file

@ -4,6 +4,11 @@ card-games NEWS -- user-visible changes
* Version 1.0.92 (pretest3: MELPA review)
** Packaging and internals
- card-games-net requires subr-x. It calls ~string-empty-p~, which
lives in subr-x before Emacs 29, so a fresh Emacs 27 failed every
networked test with a void function; the header promises 26.1.
- The SVG smoke and region tests skip, rather than fail, in an Emacs
built without SVG support. An Emacs with SVG runs them as before.
- The networked 500 client no longer patches game commands with
advice. Player commands submit their action through the new
~card-games-bid-submit~ generic; a joining Emacs plays a